Re: [AMBER-Developers] AMBER11 bugfix #19 is broken

From: Ross Walker <>
Date: Wed, 23 Nov 2011 06:55:53 -0800

This is also, I believe an issue with using git and cherry picking to make bugfixes rather than the old fashioned way of making them manually. Git commits do not tend to be atomic, building on previous commits that added new features etc and not just fixing bugs. Thus for fairly complex bugfixes it is necessary to go through and manually back port the fix to amber 11, working around all the new features etc that have been added to amber 12 in the meantime.

The current bugfix.19 scares me since clearly the bugfixes amber11 was not even built, let alone having the test cases run to make sure the fix was good and did not break a ton of stuff in the older code.


On Nov 23, 2011, at 5:59, Mark Williamson <> wrote:

> Dear all,
> Seeing this on a CUDA compile with the latest bug fixes (23/11/2011):
> mpicc -ip -O3 -no-prec-div -xHost -DMPICH_IGNORE_CXX_SEEK
> -DMPICH_IGNORE_CXX_SEEK -I/usr/local/Cluster-Apps/cuda/3.2/cuda/include
> -IB40C -IB40C/KernelCommon
> -I/usr/local/Cluster-Apps.nehalem/mvapich2/1.6/ofa/include -c gpu.cpp
> gpu.cpp(445): error: class "_gpuContext" has no member "totalMemory"
> if (gpu->totalMemory < 2 * 1024 * 1024 * 1024)
> ^
> gpu.cpp(445): warning #61: integer operation result is out of range
> if (gpu->totalMemory < 2 * 1024 * 1024 * 1024)
> I think this is incorrect; totalMemory does not exist, it should either
> be: totalGPUMemory or totalCPUMemory. Is this something local to me or
> have these patches not been tested before being released? Secondly, the
> subsequent warning sounds a bit worrying as well.
> Seeing that the cruise control framework is now in place, it might be an
> idea to introduce a test that automatically generates a patch from the
> amber11-with-patches and at15-with-patches git branches and attempts to
> apply them to the tagged amber11/at15 release branch and then builds and
> tests etc. This should hopefully prevent the above from happening.
> Regards,
> Mark
> _______________________________________________
> AMBER-Developers mailing list

AMBER-Developers mailing list
Received on Wed Nov 23 2011 - 07:00:05 PST
Custom Search