Re: [AMBER-Developers] Code review of pmemd.cuda

From: David Case <david.case.rutgers.edu>
Date: Mon, 17 Apr 2017 21:14:30 -0400

On Mon, Apr 17, 2017, Ruxi Qi wrote:

>
> FYI, trailing whitespace can be easily eliminated by the sed in-place
> substitution as follows, say to process all .F90 files in batch, do:
>
> sed -i "s/\s\+$//g" *.F90

True, but let's not do this just for the sake of doing it, or because
some integration script or compiler complains about trailing whitespace.
Large-scale changes like this can make it impossible to track true code
changes, and for really minimal gain.

Even with Dave's changes, some which were made to satisfy a rather arbitrary
96-character line limit, have to balance the pain of having some
long lines with the pain of not being able to compare code to earlier versions.

Establishing consistent indentation at the beginning of lines (to make
code flow and logic clearer) is probably worth the pain in most cases.
Removing trailing whitespace is often not worth the pain.

....dac


_______________________________________________
AMBER-Developers mailing list
AMBER-Developers.ambermd.org
http://lists.ambermd.org/mailman/listinfo/amber-developers
Received on Mon Apr 17 2017 - 18:30:02 PDT
Custom Search