Hi,
As a way to encourage best practices, here are some comments:
1. Clarity - communicate effectively.
commit ad2afeaf39e9a8ddc9b2f59a8583cbe2e633a78a
configure: users do not need to set AMBERHOME to install it
This log leaves no doubt about intent.
Please write accurate logs because some actually do read the logs.
2. Generality - validate user inputs.
What the commit above did in practice was to disable the existing
user validation of AMBERHOME. We should try to support a broad range
of users which includes the dumb ones and the forgetful ones...
For more principles of programming, including some on testing, see
.book{kernighan99,
author = "{Brian W. Kernighan and Rob Pike}",
title = "The Practice of Programming",
publisher = "Addison--Wesley",
address = "Reading, Mass.",
year = 1999 }
scott
On Mon, Feb 06, 2017 at 02:19:27PM -0500, Hai Nguyen wrote:
> On Mon, Feb 6, 2017 at 2:12 PM, Scott Brozell <sbrozell.rci.rutgers.edu>
> > Just to set the record straight, I was not referring to --skip-python.
> > As i wrote in my post, an example is the commit regarding AMBERHOME;
> > that commit added this to configure:
> > export AMBERHOME=`pwd`
> >
> > Not testing this in an environment where AMBERHOME is undefined
> > is like adding feature x to program y and then not testing the
> > x y combination.
> >
> >
> Just make thing clear: My comment in $AMBERHOME/configure about no need to
> set AMBERHOME is actually mis-leading. I only meant that user do not need
> to explicitly doing
>
> export AMBERHOME=`pwd` before running ./configure. (Of course he/shell can
> still do that).
>
> but he/she still need to source amber.sh before "make install" (which also
> setting AMBERHOME env).
>
> So basically AMBERHOME is never been undefined at install time. (that's why
> I have never tested this).
_______________________________________________
AMBER-Developers mailing list
AMBER-Developers.ambermd.org
http://lists.ambermd.org/mailman/listinfo/amber-developers
Received on Mon Feb 06 2017 - 13:30:02 PST
