Hi,
On Sun, Feb 12, 2012 at 06:07:18PM -0500, case wrote:
> On Sun, Feb 12, 2012, Scott Brozell wrote:
> >
> > The preprocessor name FFTW2 is still used in 4 files in
> > ./AmberTools/src/pbsa/
>
> But none of these are "active" most are commented out, and the rest are
> no-ops, generating the same code whether or not FFTW2 is defined. (Would be
> nice to get this cleaned up).
It was not obvious from grepping that fftw2 was "inactive".
E.g.:
./pb_force.F90:1250:# ifdef FFTW2
./pb_force.F90:1251: write(6,*) "Calling pb_fftsolv fftw2"
Programmers should "imagine" that they are maintainers or bugfixers.
An early step in those processes is grepping.
Finding false positives wastes time.
scott
_______________________________________________
AMBER-Developers mailing list
AMBER-Developers.ambermd.org
http://lists.ambermd.org/mailman/listinfo/amber-developers
Received on Sun Feb 12 2012 - 16:00:02 PST
