On Fri, Aug 21, 2009, Ross Walker wrote:
>
> Note a lot of the issues with the make clean, especially in the test
> directory come from the fact that there is no longer and standard naming
> conventions for test cases. I think *.dif is still used everywhere but then
> we have people creating mdin files from the run scripts with random names,
> we have mdout.foo and foo.out, restart.bar and bar.rst etc etc. I think it
> makes more sense to take a big cup of coffee and have a pass through the
> entire test structure to standardize things before modifying the make file
> to include as many options as you can think of.
An alternative: avoid the big cup of coffee, so that you are nice and calm
when attempting this task!
Once idea: consider the following patch to dacdif:
RCS file: /home/amber_cvs/cvsroot/amber11/test/dacdif,v
retrieving revision 10.1
diff -r10.1 dacdif
260c260
< /bin/rm $path.$dif_ext
---
> /bin/rm $path.$dif_ext $path
This has the effect that if a test PASSES, the new output is removed (which
should be OK since it is essentially the same as the saved file.) If the test
FAILS, then the (bad) output file is still around for examination.
Ideally, the test cases individually should clean up after themselves. That
is, it should not be necessary to have a separate script to do this. But this
is grunt work, as is Ross' suggestion....
Final note: the amber11/src/Makefile_at clean target already cleans out stuff
in amber11/lib; a similar behavior could/should be added to
amber11/src/Makefile.
...regards...dave
_______________________________________________
AMBER-Developers mailing list
AMBER-Developers.ambermd.org
http://lists.ambermd.org/mailman/listinfo/amber-developers
Received on Fri Aug 21 2009 - 09:11:10 PDT
