Re: [AMBER-Developers] CHAMBER string lengths

From: Mark Williamson <mjw.sdsc.edu>
Date: Fri, 26 Mar 2010 13:18:47 -0700

Tyler Luchko wrote:
> Hello,
>
> Would it be possible to increase the hard coded string lengths in
> CHAMBER? Currently, all of the CHAMBER tests fail to run unless I
> increase the string length for file names from the current 80 characters
> to 128 or greater (my paths seem to be about 5 characters too long). The
> attached patch has the minimum number of changes (1) I need to pass all
> of the tests.
>
> Tyler
>
>
> ------------------------------------------------------------------------
>
> ? chamber.patch
> Index: psfprm.f
> ===================================================================
> RCS file: /cvsroot/amber11/src/chamber/psfprm.f,v
> retrieving revision 10.71
> diff -u -r10.71 psfprm.f
> --- psfprm.f 28 Oct 2009 00:26:05 -0000 10.71
> +++ psfprm.f 26 Mar 2010 20:07:22 -0000
> .@ -25,7 +25,7 @@
> !Flags read in from the first line of the PSF: PSF, CMAP, CHEQ etc
> character(len=8), dimension(:), allocatable :: psf_flags
>
> - character(len=80) :: outu_name,psf_filename,prmtop_filename, &
> + character(len=256) :: outu_name,psf_filename,prmtop_filename, &
> param_filename, topology_filename, &
> chmcrd_filename, chmrst_filename, inpcrd_filename
> integer,parameter :: maxwrd=40
>
>
> ------------------------------------------------------------------------

I can't see a problem offhand with doing this. I've just tried this
patch and all the chamber tests (make -f Makefile_at test.chamber) pass.
I'll add it in.

regards,

Mark

_______________________________________________
AMBER-Developers mailing list
AMBER-Developers.ambermd.org
http://lists.ambermd.org/mailman/listinfo/amber-developers
Received on Fri Mar 26 2010 - 13:30:03 PDT
Custom Search