Re: [AMBER-Developers] bug in transformWatershell/actions.c (AmberTools 1.3)

From: Hannes Loeffler <Hannes.Loeffler.stfc.ac.uk>
Date: Tue, 23 Feb 2010 11:32:54 +0000

On Tue, 23 Feb 2010 09:59:35 +0000
Hannes Loeffler <Hannes.Loeffler.stfc.ac.uk> wrote:

> On Tue, 23 Feb 2010 09:45:32 +0000
> Hannes Loeffler <Hannes.Loeffler.stfc.ac.uk> wrote:
>
> > I think the better solution would be
> >
> > buffer = getArgumentString(argumentStackPointer, NULL);
> > if (buffer != NULL)
> > info->solventMask = processAtomMask(buffer, action->state);
> > else
> > info->solventMask = state->solventMask;
> > safe_free(buffer);
>
> Sorry, I obviously assumed
>
> state = action->state;
>
> somewhere earlier in the code.


The only problem is that when info->solventMask points to
state->solventMask the memory can't be freed because in ptrajCleanup
(ptraj.c) ptrajClearState is executed (and hence state points to NULL)
before the PTRAJ_CLEANUP action.

_______________________________________________
AMBER-Developers mailing list
AMBER-Developers.ambermd.org
http://lists.ambermd.org/mailman/listinfo/amber-developers
Received on Tue Feb 23 2010 - 04:00:02 PST
Custom Search